Aligning muon alignment code by kandrosov · Pull Request #51083 · cms-sw/cmssw

kandrosov · 2026-05-28T14:04:12Z

PR description:

The muon alignment code was diverged from the central CMSSW. In fact, all muon alignments for Run 3 were produced using private forks. The goal of this PR is to rebase modifications made over the past few years onto the current CMSSW. In this PR, we would like to keep the code as close as possible to what was used for Run 3 alignments to provide a reference point. Once it is merged, we plan to refactor/modernize the code and introduce new developments for Phase 2.

PR validation:

Alignment results obtained with the "usual Run 3 alignment code" and this merged version of the code are compatible.

FYI @acagnotta

cmsbuild · 2026-05-28T14:04:45Z

cms-bot internal usage

cmsbuild · 2026-05-28T14:06:26Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51083/49547

There are other open Pull requests which might conflict with changes you have proposed:
- File Alignment/CommonAlignmentMonitor/plugins/AlignmentMonitorMuonSystemMap1D.cc modified in PR(s): [ALCA-DB] Drop Geometry/CommonDetUnit package #51075
- File Alignment/CommonAlignmentMonitor/plugins/AlignmentMonitorMuonVsCurvature.cc modified in PR(s): [ALCA-DB] Drop Geometry/CommonDetUnit package #51075
- File Alignment/CommonAlignmentMonitor/plugins/AlignmentMonitorSegmentDifferences.cc modified in PR(s): [ALCA-DB] Drop Geometry/CommonDetUnit package #51075
- File Alignment/MuonAlignmentAlgorithms/interface/MuonResidualsFromTrack.h modified in PR(s): [ALCA-DB] Drop Geometry/CommonDetUnit package #51075
- File Alignment/MuonAlignmentAlgorithms/interface/SegmentToTrackAssociator.h modified in PR(s): [ALCA-DB] Drop Geometry/CommonDetUnit package #51075
- File Alignment/MuonAlignmentAlgorithms/plugins/MuonAlignmentFromReference.cc modified in PR(s): [ALCA-DB] Drop Geometry/CommonDetUnit package #51075
- File TrackingTools/TrackRefitter/interface/TrackTransformer.h modified in PR(s): [RECONSTRUCTION] Drop Geometry/CommonDetUnit package #51076

cmsbuild · 2026-05-28T14:06:56Z

A new Pull Request was created by @kandrosov for master.

It involves the following packages:

Alignment/CommonAlignmentMonitor (alca)
Alignment/CommonAlignmentProducer (alca)
Alignment/MuonAlignmentAlgorithms (alca)
TrackingTools/TrackRefitter (reconstruction)

@Alejandro1400, @JanChyczynski, @Moanwar, @arunhep, @atpathak, @cmsbuild, @jfernan2, @mandrenguyen, @perrotta, @srimanob can you please review it and eventually sign? Thanks.
@24LopezR, @CeliaFernandez, @Fedespring, @GiacomoSguazzoni, @HuguesBrun, @VinInn, @VourMa, @abbiendi, @bellan, @cericeci, @dgulhan, @elusian, @felicepantaleo, @fsimone91, @gpetruc, @jhgoh, @llunerti, @mmasciov, @mmusich, @mtosi, @pakhotin, @rovere, @rsreds, @tlampen, @tocheng, @trocino, @yuanchao this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

perrotta · 2026-05-28T14:14:37Z

please test

perrotta · 2026-05-28T14:18:47Z

Alignment results obtained with the "usual Run 3 alignment code" and this merged version of the code are compatible.

@kandrosov please provide evidence for it, in particular about what do you mean by "compatible". Did you present the comparison somewhere (e.g. Muon or Tracking POG, CondPrep meetings)?

cmsbuild · 2026-05-28T15:03:05Z

-1

Failed Tests: HeaderConsistency UnitTests RelVals RelVals-INPUT AddOn
Size: This PR adds an extra 132KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd7c7b/53541/summary.html
COMMIT: 4ef6830
CMSSW: CMSSW_17_0_X_2026-05-28-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51083/53541/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 2 errors in the following unit tests:

---> test test_MC_23_crosscheck had ERRORS
---> test test_MC_22_crosscheck had ERRORS

Failed RelVals

135.4

----- Begin Fatal Exception 28-May-2026 16:36:16 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=GlobalMuonProducer label='globalMuons'
Exception Message:
MissingParameter: Parameter 'RefitMuonHits' not found.
----- End Fatal Exception -------------------------------------------------

2025.0000002

----- Begin Fatal Exception 28-May-2026 16:41:00 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=TrackingRecoMaterialAnalyser label='materialDumperAnalyzer'
Exception Message:
MissingParameter: Parameter 'RefitMuonHits' not found.
----- End Fatal Exception -------------------------------------------------

2024.0070001

----- Begin Fatal Exception 28-May-2026 16:39:29 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=TrackingRecoMaterialAnalyser label='materialDumperAnalyzer'
Exception Message:
MissingParameter: Parameter 'RefitMuonHits' not found.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

Failed RelVals-INPUT

138.5138.5_ExpressCollisions2021/step2_ExpressCollisions2021.log
138.4138.4_PromptCollisions2021/step2_PromptCollisions2021.log
138.2138.2_ExpressCosmics2021/step2_ExpressCosmics2021.log

Expand to see more relval errors ...

Failed AddOn Tests

fastsim

----- Begin Fatal Exception 28-May-2026 16:32:36 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=GlobalMuonProducer label='globalMuons'
Exception Message:
MissingParameter: Parameter 'RefitMuonHits' not found.
----- End Fatal Exception -------------------------------------------------

fastsim1

----- Begin Fatal Exception 28-May-2026 16:32:37 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=GlobalMuonProducer label='globalMuons'
Exception Message:
MissingParameter: Parameter 'RefitMuonHits' not found.
----- End Fatal Exception -------------------------------------------------

fastsim2

----- Begin Fatal Exception 28-May-2026 16:32:41 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=GlobalMuonProducer label='globalMuons'
Exception Message:
MissingParameter: Parameter 'RefitMuonHits' not found.
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

cmsbuild · 2026-05-28T20:36:18Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51083/49559

There are other open Pull requests which might conflict with changes you have proposed:
- File Alignment/CommonAlignmentMonitor/plugins/AlignmentMonitorMuonSystemMap1D.cc modified in PR(s): [ALCA-DB] Drop Geometry/CommonDetUnit package #51075
- File Alignment/CommonAlignmentMonitor/plugins/AlignmentMonitorMuonVsCurvature.cc modified in PR(s): [ALCA-DB] Drop Geometry/CommonDetUnit package #51075
- File Alignment/CommonAlignmentMonitor/plugins/AlignmentMonitorSegmentDifferences.cc modified in PR(s): [ALCA-DB] Drop Geometry/CommonDetUnit package #51075
- File Alignment/MuonAlignmentAlgorithms/interface/MuonResidualsFromTrack.h modified in PR(s): [ALCA-DB] Drop Geometry/CommonDetUnit package #51075
- File Alignment/MuonAlignmentAlgorithms/interface/SegmentToTrackAssociator.h modified in PR(s): [ALCA-DB] Drop Geometry/CommonDetUnit package #51075
- File Alignment/MuonAlignmentAlgorithms/plugins/MuonAlignmentFromReference.cc modified in PR(s): [ALCA-DB] Drop Geometry/CommonDetUnit package #51075
- File TrackingTools/TrackRefitter/interface/TrackTransformer.h modified in PR(s): [RECONSTRUCTION] Drop Geometry/CommonDetUnit package #51076

cmsbuild · 2026-05-28T20:36:45Z

Pull request #51083 was updated. @Alejandro1400, @JanChyczynski, @Moanwar, @arunhep, @atpathak, @cmsbuild, @ctarricone, @gabrielmscampos, @jfernan2, @mandrenguyen, @perrotta, @rseidita, @srimanob can you please check and sign again.

Moanwar · 2026-05-29T06:05:09Z

@cmsbuild please test

perrotta · 2026-06-30T15:20:49Z

It remains inteded that this PR will get signed by alca only after the presentation in the CondProp meeting that you are anticipating here above

Hi @kandrosov @acagnotta are there news about the planned presentation of this updated code and its results, in a CondPrep meeting?

acagnotta · 2026-07-13T12:28:08Z

It remains inteded that this PR will get signed by alca only after the presentation in the CondProp meeting that you are anticipating here above

Hi @kandrosov @acagnotta are there news about the planned presentation of this updated code and its results, in a CondPrep meeting?

Hi @perrotta, sorry for the late reply. I scheduled a contribution at Conditions Preparations meeting for today, unfortunately the meeting will be only virtual. Link to the presentation, let us know if you have any questions.

perrotta · 2026-07-14T09:55:47Z

@acagnotta @kandrosov thank you for the link to the "virtual" presentation at the CondPrep meeting of July 13.
That presentation assesses that this PR is just intended to port in central CMSSW the private fork that was used over the past few years for the Track Based Muon Alignmenmt. It is therefore not expected that the outputs of the alignment script obtained withi this PR are necessarily fully compatible with those obtained with the (outdated and non-used) code currently in CMSSW. In this respect, the presentation that you linked confirms that the output obtained with the code updates that you are submitting here do correspond to what was obtained by running the private script during the latest alignment campaigns.

This is enough for me to eventually sign this PR for AlCa. Before doiing so, could you please consider the few small improvements suggested here above? And possibly also squash all commits into a single one, for easier future tracking of the modifications applied to the code?

- Adapted code to be compatible with the latest CMSSW version - Implemented review comments

cmsbuild · 2026-08-07T13:12:15Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51083/50502

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoMTD/TrackExtender/plugins/TrackExtenderWithMTD.cc modified in PR(s): Implementation of MTD track extender for muons #50029

cmsbuild · 2026-08-07T13:12:37Z

Pull request #51083 was updated. @Alejandro1400, @EltonSh, @JanChyczynski, @Moanwar, @arunhep, @cmsbuild, @jfernan2, @mandrenguyen, @perrotta, @srimanob can you please check and sign again.

perrotta · 2026-08-12T10:30:55Z

please test

cmsbuild · 2026-08-12T12:20:15Z

-1

Failed Tests: UnitTests
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd7c7b/55277/summary.html
COMMIT: 57c6986
CMSSW: CMSSW_20_1_X_2026-08-12-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51083/55277/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3679791
DQMHistoTests: Total failures: 41
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3679732
DQMHistoTests: Total skipped: 18
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 199 log files, 169 edm output root files, 46 DQM output files
TriggerResults: no differences found

perrotta · 2026-08-13T07:23:59Z

+alca

The Muon alignment code that is currently in the release is not the one actually used for muon alignment (using semi-private muon alignment code and tools): this PR ports in CMSSW the code in use.
Changes outside the private scripts are only those needed to add one extra paramenter in TrackingTools/TrackRefitter/src/TrackTransformer.cc‎
- Default in them remains the same as before everywhere but for the MuonAlignmentFromReferenceGlobalMuonRefit, which does not enter standard reconstruction workflow, only Muon alignment ones, as far as I can tell

mmusich · 2026-08-24T20:44:49Z

@cmsbuild, please test

to refresh tests

cmsbuild · 2026-08-24T23:00:11Z

-1

Failed Tests: UnitTests
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd7c7b/55528/summary.html
COMMIT: 57c6986
CMSSW: CMSSW_20_1_X_2026-08-24-1100/el9_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51083/55528/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 1 errors in the following unit tests:

---> test testAlignmentStats had ERRORS

Comparison Summary

Summary:

You potentially added 4 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 47
DQMHistoTests: Total histograms compared: 3836516
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3836498
DQMHistoTests: Total skipped: 18
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
Checked 203 log files, 173 edm output root files, 47 DQM output files
TriggerResults: no differences found

mmusich · 2026-09-04T06:50:41Z

@cmsbuild, please test

now tests should finally go smoothly (?)

cmsbuild · 2026-09-04T09:32:07Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd7c7b/55700/summary.html
COMMIT: 57c6986
CMSSW: CMSSW_20_1_X_2026-09-03-2300/el9_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51083/55700/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 47
DQMHistoTests: Total histograms compared: 3836516
DQMHistoTests: Total failures: 19
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3836479
DQMHistoTests: Total skipped: 18
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
Checked 203 log files, 173 edm output root files, 47 DQM output files
TriggerResults: no differences found

cmsbuild added this to the CMSSW_17_0_X milestone May 28, 2026

cmsbuild added reconstruction-pending alca-pending pending-signatures tests-pending orp-pending code-checks-pending tracking labels May 28, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels May 28, 2026

cmsbuild added tests-started and removed tests-pending labels May 28, 2026

cmsbuild added tests-rejected dqm-pending tests-pending code-checks-pending and removed tests-started tests-rejected code-checks-approved labels May 28, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels May 28, 2026

cmsbuild modified the milestones: CMSSW_20_1_X, CMSSW_20_0_X Jun 9, 2026

cmsbuild mentioned this pull request Jun 29, 2026

RecoMTD: extract TrackSegments into shared TimingTools header #51374

Merged

cmsbuild modified the milestones: CMSSW_20_0_X, CMSSW_20_1_X Jun 30, 2026

cmsbuild mentioned this pull request Jul 23, 2026

RecoMTD/TrackExtender: extract MTDHitMatcher standalone class #51550

Merged

Merged modifications from private muon alignment forks

57c6986

- Adapted code to be compatible with the latest CMSSW version - Implemented review comments

kandrosov force-pushed the MuonAlignment_CMSSW_17_0_X branch from 473cacd to 57c6986 Compare August 7, 2026 13:09

cmsbuild added reconstruction-pending code-checks-pending and removed reconstruction-approved code-checks-approved labels Aug 7, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 7, 2026

cmsbuild added tests-started and removed tests-pending labels Aug 12, 2026

cmsbuild removed the tests-started label Aug 12, 2026

Uh oh!

Conversation

kandrosov commented May 28, 2026

PR description:

PR validation:

Uh oh!

cmsbuild commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented May 28, 2026

Uh oh!

cmsbuild commented May 28, 2026

Uh oh!

perrotta commented May 28, 2026

Uh oh!

perrotta commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented May 28, 2026

Failed Unit Tests

Failed RelVals

Failed RelVals-INPUT

Failed AddOn Tests

Uh oh!

cmsbuild commented May 28, 2026

Uh oh!

cmsbuild commented May 28, 2026

Uh oh!

Moanwar commented May 29, 2026

Uh oh!

perrotta commented Jun 30, 2026

Uh oh!

acagnotta commented Jul 13, 2026

Uh oh!

perrotta commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Aug 7, 2026

Uh oh!

cmsbuild commented Aug 7, 2026

Uh oh!

perrotta commented Aug 12, 2026

Uh oh!

cmsbuild commented Aug 12, 2026

Failed Unit Tests

Comparison Summary

Uh oh!

perrotta commented Aug 13, 2026

Uh oh!

mmusich commented Aug 24, 2026

Uh oh!

cmsbuild commented Aug 24, 2026

Failed Unit Tests

Comparison Summary

Uh oh!

mmusich commented Sep 4, 2026

Uh oh!

cmsbuild commented Sep 4, 2026

Comparison Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

cmsbuild commented May 28, 2026 •

edited

Loading

perrotta commented May 28, 2026 •

edited

Loading

perrotta commented Jul 14, 2026 •

edited

Loading